X-Git-Url: https://git.njae.me.uk/?a=blobdiff_plain;f=app%2Fcontrollers%2Ffeed_controller.rb;h=819dab13c0dd344c376e38f73d544ba9a2fea61e;hb=9afca4a2a5790ed8842a7e5f0a3a3c716d28bb24;hp=30ddb0c6668cfdbe1bc12cfd26fd93ca15492de2;hpb=a5e58d33eef0f98067c18fba842fc5a3539d1c9a;p=feedcatcher.git

diff --git a/app/controllers/feed_controller.rb b/app/controllers/feed_controller.rb
index 30ddb0c..819dab1 100644
--- a/app/controllers/feed_controller.rb
+++ b/app/controllers/feed_controller.rb
@@ -12,7 +12,7 @@ class FeedController < ApplicationController
 
   
   def show
-    if valid_feed_name?(params[:feed_name])
+    if FeedItem::valid_feed_name?(params[:feed_name])
       @feed_items = FeedItem.find_all_by_feed_name(params[:feed_name])
       @feed_name = params[:feed_name]
       respond_to do |format|
@@ -36,7 +36,7 @@ class FeedController < ApplicationController
 
 
   def update
-    if valid_feed_name?(params[:feed_name])
+    if FeedItem::valid_feed_name?(params[:feed_name])
       item = FeedItem.find_by_feed_name_and_title(params[:feed_name], params[:title])
       if item
         if params[:description] == ''
@@ -59,15 +59,6 @@ class FeedController < ApplicationController
 
   private
 
-  def valid_feed_name?(feed_name)
-    Rack::Utils::escape(feed_name) == feed_name and
-      Rack::Utils::unescape(feed_name) == feed_name and
-      feed_name != 'index' and
-      feed_name != 'show' and
-      feed_name != 'update' and
-      feed_name != 'action'
-  end
-
 
   def create_item
     item = FeedItem.new(:feed_name => params[:feed_name],
@@ -107,13 +98,13 @@ class FeedController < ApplicationController
 
   def destroy_item(item)
     if item.destroy
-      flash[:notice] = "Element #{params[:title]} destroyed"
+      flash[:notice] = "Element #{params[:title]} deleted"
       respond_to do |format|
         format.html { redirect_to feed_url(params[:feed_name]) }
         format.rss  { head :ok }
       end
     else
-      flash[:notice] = "Element #{params[:title]} could not be destroyed"
+      flash[:notice] = "Element #{params[:title]} could not be deleted"
       respond_to do |format|
         format.html { redirect_to feed_url(params[:feed_name]) }
         format.rss  { head :unprocessable_entity }